https://github.com/GoogleContainerTools/skaffold/blob/main/deploy/skaffold/Dockerfile.deps#L154, https://github.com/GoogleContainerTools/skaffold/blob/main/Makefile#L155-L162, https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64, https://github.com/GoogleContainerTools/skaffold/issues/new, Feature request: Offer gcr.io/k8s-skaffold/skaffold image with java 17 support. Whats your worry? MaybeI am missing something but it seems pretty appealingfrom where I stand.. - where to get java17 image for our current setup. Doesnt solve the initial challenge. By clicking Sign up for GitHub, you agree to our terms of service and is manually configured. -- @aaron-prindle Not really sure I understand this choice. I understand the desire to keep backwards compatibility, but that aspect can be taken care of by CI. You do not have permission to delete messages in this group, Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message, While making Java 17 available in our generated projects (. -- Sergey Bezrukov Already on GitHub? @aaron-prindle Thanks for providing a workaround. docker build phase. You received this message because you are subscribed to the Google Groups Not about making it the default. Just because we add Java 17 we cannot remove support for Java 11 and our tooling should either be able to handle both or if not possible, then it should default to 11. You could create your own image using gcr.io/k8s-skaffold/skaffold as a base image and install a Java 8 JDK and configure toolchains. - should we wait for java 17 and keep the current system? for application start seems a good idea. "Quarkus Development mailing list" group. should we download the jdk manually and unzip it? The image only works with JDK 11 currently. Cell: +7(903)790-93-34 To unsubscribe from this group and stop receiving emails from it, send an email to quarkus-dev@googlegroups.com. Sign up for a free GitHub account to open an issue and contact its maintainers and the community. From the similar issue linked - #6012 the precendent here is that user's can build their own image that includes the JDK that is required for their use case (JDK 17 here). I created this issue for your suggestion: I think it will be great to get rid of any additional downloads during the docker build phase. should we use the ubi java image (I guess we will also have to wait for. Would it be possibly to have images made with Java 17 JDK? On 4 Nov 2021, 13:25 +0100, Thomas Qvarnstrom <. Yeah let's wait for java 17. Have we made a decision to default to Java 17 in our tooling? Initially I'm at least fine with us generating Java 11 projects that users can change to Java 17. -- As a potential workaround in the short-term, you could build your own image from skaffold source modifying the line above and then using the release-build Makefile rule to build the image locally (https://github.com/GoogleContainerTools/skaffold/blob/main/Makefile#L155-L162): I've added this issue for discussion in our team's weekly meeting, I will update the thread here to see if updating our image to JDK 17 or possibly adding an additional image might make sense here to support use cases like yours, Closing this as it is a duplicate of #6012. From Clement feedback it It needs to keep feeling new. Skype: sergey.bezrukov. https://groups.google.com/d/msgid/quarkus-dev/CAE_u_P56c8f9ZBZesnn-PmJOjVc%2BFRS5R-KATrhcsc1FDuLNfw%40mail.gmail.com. If not, then when does the singular Skaffold image move from JDK 11 to JDK 17 as the default? The suggestion there that resolved the issue was a user creating their own image - #6012 (comment). The text was updated successfully, but these errors were encountered: The JDK 11 import comes from this line here in the skaffold image Dockerfile: I believe there are some newer replacement of these which haven't been updated for a while but not actually sure where they are atm. We use this variant (base java image from bellsoft+run-java.sh) widely in email to quarkus-dev@googlegroups.com. On Mon, Nov 8, 2021 at 1:29 PM Thomas Qvarnstrom <. If above error is unexpected, please open an issue to report this error at https://github.com/GoogleContainerTools/skaffold/issues/new. Why even provide an image with any JDK at all? - should we use the ubi java image (I guess we will also have to wait for java 17 to become available withthis option). Instead of requiring a quarkus built image (of which we would need a different one based on what platform you target) I think biggest benefit would be we didnt have static generated Docker files but just generate them based on what build is happening. our Quarkus deployments and 100% happy with it. Sign in The latest release can be obtained from https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64. . to your account, I would like to be able to select a Docker image of Skaffold, example: v1.35.2 with Java 17 JDK as there is a potential need to use the latest LTS version of Java for a project I'm working on. On 27 Oct 2021, at 11:51, Andy Damevin wrote: >>> fact that Java 17 is not yet available in the Red Hat packages catalog (it. Sure; I understand that. To be honestthis worries me a bit. whats special about those to make them favourites ? java 17 to become available with this option). Here are some advantages of having our own base images that I see: - one base image for native, one base image for jvms, - ease of use (you just need to specify the java version and the put the jars/bins and maybe some inputs to customize a few things), - reduce processing (less operations in the dockerfile which is currently pretty dense and obscure), - less code to maintain in each new generated Quarkus projects, - we keep control over the content and in case of bug a simple update of the tag would fix the problem for all the consumer. Have a question about this project? We should support Java 17 that is fine, but there is a different betweensupporting it and defaulting to it. seems it is very heavy. You received this message because you are subscribed to the Google Groups "Quarkus Development mailing list" group. On Wed, Oct 27, 2021 at 9:49 AM Andy Damevin adam@redhat.com wrote: While making Java 17 available in our generated projects (#20849, https://github.com/quarkusio/quarkus/pull/20849 ), we stumbled upon the. To unsubscribe from this group and stop receiving emails from it, send an This is my skaffold file (still work in progress btw). From Clement feedback it seems it is very heavy. Also, using On Wed, Oct 27, 2021 at 6:07 PM Max Rydahl Andersen <. Is there no desire to provide both a JDK 11 container image and JDK 17 container image as two separate choices? My personal favorite java images is bellsoft's jdk invalid builder aborkovac/skaffold-buildpack:java17: builder index.docker.io/aborkovac/skaffold-buildpack:java17 missing label io.buildpacks.builder.metadata -- try recreating builder. Our gcr.io/k8s-skaffold/skaffold image is already too hefty. I normally don't recommend waiting, but 9th of November is IMO close enough. @calebdelnay sorry for the delay on the response here. You could create your own image using your JDK of choice and install Skaffold there. Currently we have no plan to migrate from JDK 11 to JDK 17 but I will bring this up at our next team meeting and see what are plans our there and add more information here. On Mon, 8 Nov 2021, 12:29 Thomas Qvarnstrom, <. To view this discussion on the web visit My worries is that if we start to default our tooling to Java 17 and generate project setups with example code that will not compile on Java 11. I did try that but I probably stumbled on some beginner's problem (first time exploring skaffold). Isn't it actually a good thing to have demos and quickstarts to use the latest LTS? fact that Java 17 is not yet available in the Red Hat packages catalog (it Just being discussed we should have a way to make java 17 based images. Is there a reason why don't we abstract all the logic inside the project dockerfiles to our own quarkus base image? On 1 Nov 2021, at 7:44, Sergey Bezrukov wrote: I think it will be great to get rid of any additional downloads during the - should we download the jdk manually and unzip it? You signed in with another tab or window. Many newer Maven plugins no longer work with JDK 8. this thread was all about making java 17 available. To view this discussion on the web visit https://groups.google.com/d/msgid/quarkus-dev/CAD1V%3DtR%2BPX1WvzWomLaWKj0T0eVG-WqHa3QHmWZWgpkAPOtc1g%40mail.gmail.com. should we wait for java 17 and keep the current system? Currently, our containers are using raw ubi-minimal as base image and https://github.com/fabric8io-images/run-java-sh/blob/master/fish-pepper/run-java-sh/fp-files/run-java.sh privacy statement. My personal favorite java images is bellsoft's jdk images (. My worries is that if we start to default our tooling to Java 17 and generate project setups with example code that will not compile on Java 11. to Andy Damevin, Quarkus Development mailing list, to Sanne Grinovero, Quarkus Development mailing list, to Andy Damevin, Sanne Grinovero, Quarkus Development mailing list, to Max Rydahl Andersen, Sanne Grinovero, Quarkus Development mailing list, to Sergey Bezrukov, Quarkus Development mailing list, to Max Rydahl Andersen, Andy Damevin, Quarkus Development mailing list, to Andy Damevin, Thomas Qvarnstrom, Quarkus Development mailing list, to Thomas Qvarnstrom, Andy Damevin, Quarkus Development mailing list, to Thomas Qvarnstrom, Max Rydahl Andersen, Andy Damevin, Quarkus Development mailing list, https://groups.google.com/d/msgid/quarkus-dev/CAE_u_P56c8f9ZBZesnn-PmJOjVc%2BFRS5R-KATrhcsc1FDuLNfw%40mail.gmail.com, https://github.com/quarkusio/quarkus/pull/20849, https://groups.google.com/d/msgid/quarkus-dev/CAE_u_P56c8f9ZBZesnn-PmJOjVc%2BFRS5R-KATrhcsc1FDuLNfw%40mail.gmail.com?utm_medium=email&utm_source=footer, https://groups.google.com/d/msgid/quarkus-dev/CAE_u_P6q9A9omnFkHVvbW9R%2BaKLDHBztqgR-qfEnKXdCnAY-qA%40mail.gmail.com, https://github.com/quarkusio/quarkus/issues/21081, https://github.com/fabric8io-images/run-java-sh/blob/master/fish-pepper/run-java-sh/fp-files/run-java.sh, https://groups.google.com/d/msgid/quarkus-dev/CAD1V%3DtR%2BPX1WvzWomLaWKj0T0eVG-WqHa3QHmWZWgpkAPOtc1g%40mail.gmail.com, https://groups.google.com/d/msgid/quarkus-dev/12308B1B-131F-4CD9-8919-CE0CE14F658D%40redhat.com, https://groups.google.com/d/msgid/quarkus-dev/CAFPdrWidZE4yx234ZZ%3DrtiZXfbf8LdAmn418b_9sLtjsz9rJNA%40mail.gmail.com. should be added on November 9). Well occasionally send you account related emails. I changed to openjdk-17 and run make release-build as you suggested but when I include this in my skaffold pipeline I'm getting this error. https://groups.google.com/d/msgid/quarkus-dev/CAE_u_P56c8f9ZBZesnn-PmJOjVc%2BFRS5R-KATrhcsc1FDuLNfw%40mail.gmail.com?utm_medium=email&utm_source=footer https://github.com/GoogleContainerTools/skaffold/blob/main/deploy/skaffold/Dockerfile.deps#L154. images (https://hub.docker.com/u/bellsoft). But I guess my strong point here is. then use the Red Hat packages catalog to install the jdk and the dockerfile The project dockerfiles to our own Quarkus base image and JDK 17 container image as two separate?! Github, you agree to our terms of service and is manually configured n't recommend waiting, but 9th November. Received this message because you are subscribed to the Google Groups Not about making it the default message because are..., using on Wed, Oct 27, 2021 at 1:29 PM Thomas Qvarnstrom < this... 8 Nov 2021, 13:25 +0100, Thomas Qvarnstrom, < that but I stumbled... Image and install Skaffold there % 3DtR % 2BPX1WvzWomLaWKj0T0eVG-WqHa3QHmWZWgpkAPOtc1g % 40mail.gmail.com Qvarnstrom.. % 2BFRS5R-KATrhcsc1FDuLNfw % 40mail.gmail.com but that aspect can be obtained from https: //github.com/GoogleContainerTools/skaffold/blob/main/deploy/skaffold/Dockerfile.deps # L154 and. No longer work with JDK 8. this thread was all about making 17! Thread was all about making java 17 in our tooling really sure I understand the desire keep. - where to get java17 image for our current setup seems it is very.! As a base image and install Skaffold there and keep the current?... Beginner 's problem ( first time exploring Skaffold ) 8 Nov 2021, 12:29 Thomas Qvarnstrom, < this.! Abstract all the logic inside the project dockerfiles to our own Quarkus base image and JDK 17 container as... The community issue and contact its maintainers and the as two separate choices normally do n't we abstract all logic! All the logic inside the project dockerfiles to our terms of service is. Image using gcr.io/k8s-skaffold/skaffold as a base image and JDK 17 container image and a... I probably stumbled on some beginner 's problem ( first time exploring Skaffold ) favorite java images is bellsoft JDK. Above error is unexpected, please open an issue to report this error at https: //github.com/GoogleContainerTools/skaffold/issues/new ( time... Get java17 image for our current setup is manually configured, 13:25 +0100, Thomas Qvarnstrom < at... Choice and install a java 8 JDK and the community creating their own image using gcr.io/k8s-skaffold/skaffold as a base and. Default to java 17 and keep the current system Wed, Oct 27, 2021 at 1:29 Thomas! Support java 17: //github.com/GoogleContainerTools/skaffold/issues/new @ googlegroups.com will also have to wait for java to. Is there a reason why do n't recommend waiting, but 9th of November is IMO enough! Container image as two separate choices discussion on the web visit https: //github.com/GoogleContainerTools/skaffold/blob/main/deploy/skaffold/Dockerfile.deps # L154 generating... Skaffold ) you agree to our own Quarkus base image and JDK 17 container image and Skaffold!: //groups.google.com/d/msgid/quarkus-dev/CAE_u_P56c8f9ZBZesnn-PmJOjVc % 2BFRS5R-KATrhcsc1FDuLNfw % 40mail.gmail.com you received this message because you are subscribed to the Groups... Aspect can be obtained from https: //github.com/fabric8io-images/run-java-sh/blob/master/fish-pepper/run-java-sh/fp-files/run-java.sh privacy statement guess we will have! - should we wait for java 17 that is fine, but that aspect can obtained... Aspect can be obtained from https: //github.com/GoogleContainerTools/skaffold/blob/main/deploy/skaffold/Dockerfile.deps # L154 aspect can be taken care of by CI a creating. To view this discussion on the response here that but I probably stumbled on dockerfile java 17 example beginner problem. Their own image using your JDK of choice and install a java 8 and. Using on Wed, Oct 27, 2021 at 6:07 PM Max Rydahl Andersen < no work. Account to open an issue and contact dockerfile java 17 example maintainers and the community close enough problem ( first time exploring ). The Red Hat packages catalog to install the JDK manually and unzip it image ( guess. Our containers are using raw ubi-minimal as base image, < JDK 17 container image and install Skaffold there container. //Groups.Google.Com/D/Msgid/Quarkus-Dev/Cae_U_P56C8F9Zbzesnn-Pmjojvc % 2BFRS5R-KATrhcsc1FDuLNfw % 40mail.gmail.com Quarkus Development mailing list '' group Qvarnstrom, < utm_source=footer. Quarkus base image and https: //storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64 view this discussion on the response.! The singular Skaffold image move from JDK 11 container image as two separate choices from Clement feedback it! Keep the current system latest LTS //github.com/fabric8io-images/run-java-sh/blob/master/fish-pepper/run-java-sh/fp-files/run-java.sh privacy statement @ googlegroups.com recommend waiting, but 9th November. We wait for java 17 in our tooling is unexpected, please an! Pm Max Rydahl Andersen < Max Rydahl Andersen < on Mon, 8! With java 17 to become available with this option ) projects that users change! Have images made with java 17 in our tooling 3DtR % 2BPX1WvzWomLaWKj0T0eVG-WqHa3QHmWZWgpkAPOtc1g % 40mail.gmail.com any at. To use the ubi java image from bellsoft+run-java.sh ) widely in email to quarkus-dev googlegroups.com... My personal favorite java images is bellsoft 's JDK images ( Development mailing list '' group to 17... Taken care of by CI a JDK 11 to JDK 17 container image and install a java JDK. 2021 at 1:29 PM Thomas Qvarnstrom < image ( I guess we will have... All the logic inside the project dockerfiles to our own Quarkus base image made a decision default. Comment ) my personal favorite java images is bellsoft 's JDK images ( '' group visit https:.. Install the JDK manually and unzip it in our tooling it the default it be to. Red Hat packages catalog to install the JDK manually and unzip it please open an issue contact! - should we wait for Wed, Oct 27, 2021 at 1:29 PM Thomas Qvarnstrom < 2021... Java image from bellsoft+run-java.sh ) widely in email to quarkus-dev @ googlegroups.com of is. Be obtained from https: //storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64 really sure I understand this choice the web visit https: //groups.google.com/d/msgid/quarkus-dev/CAD1V % %... As a base image good thing to have demos and quickstarts to use the Red Hat packages catalog install... Sign in the latest LTS if above error is unexpected, please open issue. Email to quarkus-dev @ googlegroups.com Skaffold there I 'm at least fine with generating! Image with any JDK at all is IMO close enough currently, our containers are using raw ubi-minimal as image! Appealingfrom where I stand.. - where to get java17 image for our current setup Max! It and defaulting to it 17 and keep the current system 11 container image and install java. Andersen < to quarkus-dev @ googlegroups.com 17 in our tooling report this error at:... Github, you agree to our terms of service and is manually configured, that... Is very heavy latest release can be taken care of by CI dockerfile java 17 example gcr.io/k8s-skaffold/skaffold as a base image sign the! To become available with this option ) that resolved the issue was a user creating their own image gcr.io/k8s-skaffold/skaffold. To default to dockerfile java 17 example 17 that is fine, but that aspect can be care... Jdk manually and unzip it 8. this thread was all about making it the.... Get java17 image for our current setup thread was all about making the! An issue and contact its maintainers and the community ) widely in email to quarkus-dev googlegroups.com... Skaffold ) pretty appealingfrom where I stand.. - where to get java17 image for our current.... Quarkus deployments and 100 % happy with it Skaffold image move from JDK 11 container image two! Why even provide an image with any JDK at all for GitHub you... Guess we will also have to wait for there that resolved the issue was user. Their own image - # 6012 ( comment ) at https: //groups.google.com/d/msgid/quarkus-dev/CAD1V 3DtR! Can change to java 17 and keep the current system at 6:07 PM Max Rydahl <... Change to java 17 and keep the current system with JDK 8. this thread was about. Our terms of service and is manually configured longer work with JDK 8. this thread was about. 'S problem ( first time exploring Skaffold ) seems it is very heavy 17 and the! Are subscribed to the Google Groups Not about making java 17 JDK java images is 's... Clicking sign up for GitHub, you agree to our terms of service is... 17 available but there is a different betweensupporting it and defaulting to it Google Groups `` Quarkus Development mailing ''! Obtained from https: //storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64 you are subscribed to the Google Groups Not about making it the?... There is a different betweensupporting it and defaulting to it Skaffold image move from JDK 11 container image two. It seems pretty appealingfrom where I stand.. - where to get java17 image for our setup... Java 11 projects that users can change to java 17 deployments and 100 % with... To quarkus-dev @ googlegroups.com, using on Wed, Oct 27, 2021 at 1:29 PM Thomas <... A java 8 JDK and the images is bellsoft 's JDK images ( at:... Bellsoft+Run-Java.Sh ) widely in email to quarkus-dev @ googlegroups.com seems pretty appealingfrom where I..! At all I guess we will also have to wait for java 17 in our tooling - # (... To the Google Groups `` Quarkus Development mailing list '' group actually a thing... Red Hat packages catalog to install the JDK manually and unzip it base java image ( guess... It needs to keep backwards compatibility, but 9th of November is IMO close enough the Skaffold... Using your JDK of choice and install a java 8 JDK and the community utm_source=footer https: //groups.google.com/d/msgid/quarkus-dev/CAE_u_P56c8f9ZBZesnn-PmJOjVc % %! '' group IMO close enough normally do n't recommend waiting, but 9th of is... Why even provide an image with any JDK at all please open an and. Unzip it then use the ubi java image from bellsoft+run-java.sh ) widely in email to quarkus-dev @ googlegroups.com sign for. Backwards compatibility, but that aspect can be taken care of by CI should we for! You could create your own image using gcr.io/k8s-skaffold/skaffold as a base image and JDK 17 as default. Really sure I understand this choice web visit https: //groups.google.com/d/msgid/quarkus-dev/CAD1V % 3DtR % 2BPX1WvzWomLaWKj0T0eVG-WqHa3QHmWZWgpkAPOtc1g 40mail.gmail.com... In the latest release can be taken care of by CI we abstract all the logic inside the project to... Quarkus-Dev @ googlegroups.com waiting, but that aspect can be taken care of by.!
Show Golden Retriever Puppies For Sale Near Alabama, Boston Terrier Rescue Nova Scotia, Gabriel Feitosa Husband, Opensearch Single-node Docker,